feat: merge new token managers #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new token managers that have the mint/burn permissions. * added a few tests * a few more tests * removed mint/burn from legacy * rename INTERCHAIN_TOKEN to INTERCHAIN_TOKEN_MINT_BURN * remove unused import and prettier * some more renaming * rever * added some docstrings * prettier * chore: restrict custom token manager deployments (#3) * some styling * fixed revert * fixed some docs * bump package version * restrict remote token manager deployment * rename MINT_BURN_FROM to CUSTOM_MINT_BURN_FROM * prettier * add comments to TokenManagerType * rename token manager types * update docs * refactor(TokenManager): simplification (#4) * refactor(TokenManager): simplification * refactor(TokenManager): unused import * update doc --------- Co-authored-by: Milap Sheth <[email protected]> Co-authored-by: re1ro <[email protected]>
…new-token-managers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 98.70% 97.65% -1.06%
==========================================
Files 16 16
Lines 541 554 +13
Branches 107 111 +4
==========================================
+ Hits 534 541 +7
- Misses 2 5 +3
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. |
…new-token-managers
milapsheth
reviewed
Apr 1, 2024
Comment on lines
-43
to
+45
| function giveToken( | ||
| uint256 tokenManagerType, | ||
| address tokenAddress, | ||
| address tokenManager, | ||
| address to, | ||
| uint256 amount | ||
| ) external payable returns (uint256) { | ||
| function giveToken(bytes32 tokenId, address to, uint256 amount) external payable returns (uint256, address) { |
There was a problem hiding this comment.
can you make these new changes in a separate PR? This PR should be a simple cherry pick of the fix. Makes it easier to audit as well.
Was the issue bytecode size? if so, you can point this PR on the other PR that adds the bytecode fix but keep the token handler refactor separate?
Co-authored-by: Milap Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.